Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: GetAwaitExpressionInfo ignores BoundConversion #54296

Merged
merged 10 commits into from
Jun 24, 2021
Merged

Bugfix: GetAwaitExpressionInfo ignores BoundConversion #54296

merged 10 commits into from
Jun 24, 2021

Conversation

bernd5
Copy link
Contributor

@bernd5 bernd5 commented Jun 22, 2021 •
edited
Loading

fixes #54298
Bugfix to handle "BoundConversion"

@bernd5 bernd5 requested a review from a team as a code owner June 22, 2021 20:07
@bernd5 bernd5 mentioned this pull request Jun 22, 2021
Closed
@bernd5
Copy link
Contributor Author

bernd5 commented Jun 23, 2021

Why is the test failing?

@AlekseyTs
Copy link
Contributor

Done with review pass (commit 6)

@AlekseyTs
Copy link
Contributor

Done with review pass (commit 9)

333fred
333fred approved these changes Jun 24, 2021
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 10)

AlekseyTs
AlekseyTs approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 10)

@AlekseyTs AlekseyTs merged commit 9193177 into dotnet:main Jun 24, 2021
@ghost ghost added this to the Next milestone Jun 24, 2021
@AlekseyTs
Copy link
Contributor

@bernd5 Thanks for the contribution.

@bernd5 bernd5 deleted the Bugfix_GetAwaitExpressionInfo branch June 24, 2021 19:18
@RikkiGibson RikkiGibson modified the milestones: Next, 17.0.P2 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cston cston cston left review comments

@333fred 333fred 333fred approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

Assignees
No one assigned
Labels
Area-Compilers
Projects
None yet
Milestone
17.0.P2
Development

Successfully merging this pull request may close these issues.

Missing handling for BoundConversion in GetAwaitExpressionInfo
5 participants
@bernd5 @AlekseyTs @333fred @cston @RikkiGibson